Repository navigation
Fork patch: Probe untraced media src writes - #13
Draft
valeriangalliat wants to merge 1 commit into
Draft
valeriangalliat wants to merge 1 commit into
valeriangalliat wants to merge 1 commit into
Conversation
Edit accuracy: accurate 271 (base branch 271), smooth 130 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (1)
|
valeriangalliat
force-pushed
the
patch/probe-untraced-media-src
branch
from
November 9, 2026 23:41
749a497 to
193db26
Compare
valeriangalliat
force-pushed
the
patch/probe-untraced-media-src
branch
from
November 10, 2026 00:52
193db26 to
b2d2e53
Compare
valeriangalliat
force-pushed
the
patch/probe-untraced-media-src
branch
from
November 10, 2026 18:00
b2d2e53 to
647ff8c
Compare
Collaborator
Author
|
🤖 AI agent: sync/2026-11-10: rebased onto upstream |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI agent: Arcade fork patch. Do not merge.
This draft shows
patch/probe-untraced-media-srcagainstmain, the upstream mirror, so the patch has one page for its diff, its revisions and its reason. Arcade's/hyperframes-updaterebases the branch ontomainand cherry-picks it ontoarcade; this PR is not part of that flow. When a rebuild changes the patch, itsgit range-diffagainst the previoussync/<date>/probe-untraced-media-srctag is posted as a comment.Why
The renderer extracts video frames from the static
srcunless a trigger makes it load the page.hasRuntimeMediaChangesonly followssrcwrites whose target it can resolve statically (getElementByIdorquerySelector('<literal>')). A write in a loop, likeroot.querySelectorAll("[data-media-key]").forEach(el => { el.src = S[key]; }), was dropped by the parser, so a timed video exported its authored clip while preview played the swapped one.The parser now keeps such writes with
selector: null, and a null selector loads the page when the document has any<video>or<audio>. Lint skips null selectors, so its output is unchanged.Untimed videos already load the page through the auto-start trigger, which is why this only shows with
data-start.Review notes
MediaSrcMutation.selectorbecomesstring | nullin@hyperframes/parsers, a breaking type change for external consumers. Arcade doesn't import it.x.src = …loads the page, even one aimed at an<img>or a plain object. That costs time, not correctness.Object.assign(el, { src }), writes after asetTimeout.alt=mediarepair doesn't cover yet. That repair needs extending before the pin ships.Verification
probeStage.test.ts71/71, two new tests: a loop write with a video probes (fails without the source change), a loop write on images only doesn't.media.test.ts137/137.tsc,oxfmt,oxlintand lefthook clean.a318cd008plus an earlier revision that included this change: 22/22. Corpus rowsetting-src-keyed-loop(ArcadeHQ/arcade#13159) fails ona318cd008alone and passes with it.Upstream
Issue filed: heygen-com/hyperframes#7504, with a repro. No upstream PR. Upstream may prefer teaching the parser the
forEachshape over "unknown target means maybe"; the issue asks.Drop when
Upstream probes media
srcwrites it cannot resolve statically.Arcade
ARC-17431 · ArcadeHQ/arcade#13159 · ArcadeHQ/arcade#13115