Skip to content

feat(frontend): /m developer mode Registry table like /w - #8166

Merged
mmabrouk merged 6 commits into
release/v0.128.9from
feat/m-parity-registry-table
Nov 6, 2026
Merged

mmabrouk merged 6 commits into
release/v0.128.9from
feat/m-parity-registry-table

Conversation

@mmabrouk

@mmabrouk mmabrouk commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Context

The /m Registry did not read like the /w one. Variants mode listed every revision under a small header instead of one row per variant. Dates had no time, Created by had no avatar, the model name was cut. There was no row selection, so several revisions or a whole variant could not be deleted at once (findings apps-registry-03, -04, -06, -10).

Changes

In beta developer mode the Registry table now works like /w:

  • Variants mode: one row per variant, showing its latest revision with its badges and deploy dots. A plus button expands the older revisions under it.
  • Columns: Name, full Model name, Created on with the time, Created by with the avatar, and Commit notes cut to one line.
  • Selection: a checkbox column from the shared ListTable selection (feat(frontend): row selection and bulk bar in the shared list table #8148). With rows selected, the header shows "N selected" with Deploy (one row) and Delete.
  • Delete: a selected variant row deletes the whole variant (archiveWorkflowVariant), and a selected revision row deletes that revision. The confirm dialog names each one. A selection that would remove every revision of the app is refused: the app is the thing to delete then. The row menu on a variant row says "Delete variant".
  • Drawer: opening a row opens the editable revision drawer from feat(frontend): editable revision drawer in /m Registry and Deployments #8157.

Without beta developer mode the Registry is unchanged: the same VariantsTable, no checkboxes, and the read-only drawer.

Follow-up: the column settings gear comes after PR 2.2, which builds the shared column menu.

This branch is stacked on #8151, with the heads of #8148 (feat/m-parity-list-selection) and #8157 (feat/m-parity-editable-drawer) merged in. Those land first, and the diff shrinks once they do.

Tests

  • registrySelection.render.test.tsx:
    • one row per variant and the expand rows;
    • the deletion plan: a selected variant takes its revisions, other revisions go one by one;
    • Deploy takes exactly one selected row;
    • Delete calls the real archive functions with only the HTTP mocked, and the test checks the exact requests (/workflows/variants/<id>/archive, then /workflows/revisions/<id>/archive, both with project_id);
    • a delete of every revision is refused.
  • variantsScreen.render.test.tsx: beta developer mode shows one checkbox row per variant; without beta there are no checkboxes.
  • /m type check and lint on the changed files.
  • Quick look on the parity data: Variants mode, an expanded variant, two rows selected, and the confirm dialog.

What to QA

  • Beta developer mode, Registry, Variants mode: one row per variant. The plus button shows the older revisions.
  • Select two revisions and click Delete. The dialog names both, and both go.
  • In Variants mode, select a variant row and click Delete. The whole variant goes.
  • Try to delete every variant. The dialog refuses.
  • Regression: without beta developer mode the Registry looks and works as before.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Website preview

Preview URL: https://pr-8166-agenta-website-preview.mahmoud-637.workers.dev

Built from 4d0d26891f466ca98b12a1c06a06df98d12b8a9c. This comment updates in place on every push.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Item Value
Status stopped
Commit 4d0d26891f466ca98b12a1c06a06df98d12b8a9c
Manual expiry (UTC) Not granted
CI deadline (UTC) Not granted
Workflow https://github.com/Agenta-AI/agenta/actions/runs/42212067842

Preview use finished or expired. Environment absence verified; retained storage requires separate provider accounting.

Post /preview as a new comment to request a one-hour preview. Repeating it while active does not extend the hour.
Preview data is disposable. Expiry is enforced by the next successful cleanup sweep, not an exact timer.
Environment deletion stops its compute. Provider-retained storage and permanent services may still be billed.

@mmabrouk

mmabrouk commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

🤖 The AI agent says: @coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

@mmabrouk I’ll start a review of the PR.

Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mmabrouk
mmabrouk changed the base branch from feat/m-parity-app-urls to release/v0.128.9 November 6, 2026 14:16
@mmabrouk
mmabrouk merged commit db241e8 into release/v0.128.9 Nov 6, 2026
26 of 28 checks passed
@mmabrouk mmabrouk added the lgtm This PR has been approved by a maintainer label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant