Skip to content

refactor: create ZipFileFlags to wrap flags - #947

Merged
Its-Just-Nans merged 3 commits into
masterfrom
creat-zip-file-flags
Aug 18, 2026
Merged

Its-Just-Nans merged 3 commits into
masterfrom
creat-zip-file-flags

Conversation

@Its-Just-Nans

Copy link
Copy Markdown
Member
  • create ZipFileFlags
  • move System to src/format/system.rs

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring looks good. The PR successfully:

  • Creates a type-safe ZipFileFlags wrapper around u16 with convenient helper methods
  • Moves System enum to a dedicated module for better code organization
  • Updates all imports and usages correctly

The changes improve code maintainability without introducing defects.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@Its-Just-Nans Its-Just-Nans changed the title refactor: create ZipFileFlags to do the matching refactor: create ZipFileFlags to wrap flags Aug 18, 2026
@Its-Just-Nans
Its-Just-Nans added this pull request to the merge queue Aug 18, 2026
Merged via the queue into master with commit 6f1530c Aug 18, 2026
134 checks passed
@Its-Just-Nans
Its-Just-Nans deleted the creat-zip-file-flags branch August 18, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant