Skip to content

feat: add a test on enum size - #939

Merged
Its-Just-Nans merged 4 commits into
masterfrom
add-test-size
Aug 17, 2026
Merged

Its-Just-Nans merged 4 commits into
masterfrom
add-test-size

Conversation

@Its-Just-Nans

Copy link
Copy Markdown
Member

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test adds valuable size validation for the ZipFileReader enum to ensure it remains memory-efficient. Two improvements needed:

  1. Remove the debug eprintln! statements that will clutter test output
  2. Add a comment explaining the 32-byte threshold for future maintainers

These changes will make the test cleaner and more maintainable without affecting functionality.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Comment thread src/read/readers.rs Outdated
Comment thread src/read/readers.rs
@Its-Just-Nans
Its-Just-Nans added this pull request to the merge queue Aug 16, 2026
Merged via the queue into master with commit ba75b3a Aug 17, 2026
134 checks passed
@Its-Just-Nans
Its-Just-Nans deleted the add-test-size branch August 17, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant