refactor: move write options to write/options.rs - #931
Merged
Merged
Conversation
Its-Just-Nans
commented
Aug 13, 2026
Member
- The PR title must conform to Conventional Commits and start with one of the types specified by the Angular convention.
Contributor
There was a problem hiding this comment.
This is a clean refactoring PR that successfully moves the write options code from src/write.rs to a new src/write/options.rs module. The changes are well-organized and all imports have been properly updated across the codebase.
The refactoring correctly:
- Moves
FileOptions,ExtendedFileOptions,FullFileOptions,SimpleFileOptions,EncryptWith, and related code tosrc/write/options.rs - Updates all import statements throughout the codebase to use the new module paths
- Moves
fficonstants fromtypes.rstoformat/ffi.rsfor better organization - Consolidates
Magicimports to useformat::magic::Magicconsistently - Adds comprehensive tests to
src/format/flags.rsfor theSystemenum
No defects or issues were identified that would block merging. The code compiles correctly and maintains all existing functionality.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.