Skip to content

refactor: move write options to write/options.rs - #931

Merged
Its-Just-Nans merged 8 commits into
masterfrom
move-write-options-to-write-options
Aug 14, 2026
Merged

Its-Just-Nans merged 8 commits into
masterfrom
move-write-options-to-write-options

Conversation

@Its-Just-Nans

Copy link
Copy Markdown
Member

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean refactoring PR that successfully moves the write options code from src/write.rs to a new src/write/options.rs module. The changes are well-organized and all imports have been properly updated across the codebase.

The refactoring correctly:

  • Moves FileOptions, ExtendedFileOptions, FullFileOptions, SimpleFileOptions, EncryptWith, and related code to src/write/options.rs
  • Updates all import statements throughout the codebase to use the new module paths
  • Moves ffi constants from types.rs to format/ffi.rs for better organization
  • Consolidates Magic imports to use format::magic::Magic consistently
  • Adds comprehensive tests to src/format/flags.rs for the System enum

No defects or issues were identified that would block merging. The code compiles correctly and maintains all existing functionality.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Comment thread src/write/options.rs Fixed
@Its-Just-Nans
Its-Just-Nans added this pull request to the merge queue Aug 14, 2026
Merged via the queue into master with commit b33e31d Aug 14, 2026
134 checks passed
@Its-Just-Nans
Its-Just-Nans deleted the move-write-options-to-write-options branch August 14, 2026 19:59
@Its-Just-Nans Its-Just-Nans mentioned this pull request Aug 15, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants