You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix unsound assumption of chunks being disjoint #89
I assume we could still do things in parallel if we want.
We could create a DisjointViews (or so) struct that holds non-overlapping ArrayBytesFixedDisjointViews and has a safe fn add(&mut self, ...) -> bool that returns if a region was safely added (would not overlap with the already contained regions) or not. Then at runtime,
create a Vec<DisjointViews> by first trying to add each view to the first DisjointViews object, then the second, … until each view has been added.
go over the vec and handle each DisjointViews object in parallel.
There could be pathological cases where that doesn’t work well, but in practice, those shouldn’t happen
Activity
LDeakin commentedon Feb 24, 2025
That sounds reasonable, but we could just be patient.
zarr-pythonmight disallow it zarr-developers/zarr-python#2855