Repository navigation
fix: reset the codec-pipeline thread pool after fork - #4483
Merged
Merged
Conversation
A forked child inherits codec_pipeline._pool pointing at threads that do not exist in the child, plus the parent's idle-semaphore permits. Submissions up to the permit count are consumed without spawning a thread, so small FusedCodecPipeline reads hang forever. Add an after_in_child hook that drops the inherited pool, size, and lock. The lock is recreated because it may have been held by a thread that no longer exists in the child. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4483 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 94 94
Lines 13659 13663 +4
=======================================
+ Hits 12937 12941 +4
Misses 722 722
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4478.
zarr.core.codec_pipelinekeeps a module-levelThreadPoolExecutorforFusedCodecPipeline. A forked child inherits_poolpointing at threads that do not exist in the child, plus the parent's idle-semaphore permits.submitconsumes a permit and returns without spawning a thread, so submissions up to the permit count queue work that nothing runs. Small multi-chunk reads hang forever. Larger reads recover once they exhaust the stale permits and spawn a real thread.reset_resources_after_forkinzarr.core.syncresets the event loop and IO thread plus the sync executor after a fork, but the codec pipeline registered noafter_in_childhook. This adds one that drops the inherited_pooland_pool_sizeand recreates_pool_lock, since the parent may have held it at fork time, which would leave the child's copy permanently locked.The regression test reads a multi-chunk array in the parent to populate the pool, then reads a 2-chunk region in a forked child. Two chunks is below the inherited permit count, so unfixed code hangs and the test fails on a 30s
gettimeout instead of blocking CI.For reviewers
Two things I would value a second look at are the decision to recreate
_pool_lockrather than reuse the inherited lock, and whether any other module-level executor state needs the same treatment. Locally the issue'sProcessPoolExecutorscript timed out at 30s unfixed and passed with the fix. The permit arithmetic was confirmed by printing_idle_semaphore._valuein parent and child.Author attestation
TODO
docs/user-guide/*.mdchanges/