Repository navigation
fix: list nested prefixes when FsspecStore path is "" or "/" - #4452
Merged
d-v-b merged 2 commits intoSep 29, 2026
Merged
Conversation
list_dir and list_prefix joined the store path and the prefix with a "/", so a store rooted at "" or "/" asked the filesystem for "/a" or "//a". ReferenceFileSystem keys entries by bare names and does not find those, so nested groups listed as empty. FsspecStore.from_url with "reference://" gives a path of "", so this affected kerchunk-style references opened the usual way. Reads were already handled by _dereference_path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
==========================================
+ Coverage 94.43% 94.44% +0.01%
==========================================
Files 93 93
Lines 13219 13221 +2
==========================================
+ Hits 12483 12487 +4
+ Misses 736 734 -2
🚀 New features to boost your workflow:
|
Contributor
|
thanks for this, and sorry for the bugged behavior. I'm having a look now |
d-v-b
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_dirandlist_prefixjoined the store path and the prefix with a "/", so a store rooted at "" or "/" asked the filesystem for "/a" or "//a".ReferenceFileSystemkeys entries by bare names and does not find those, so nested groups listed as empty.FsspecStore.from_urlwith "reference://" gives a path of "", so this affected kerchunk-style references opened the usual way. Reads were already handled by_dereference_path.With zarr 3.4.0 and fsspec 2026.9.0, the output is:
Author attestation
TODO
docs/user-guide/*.mdchanges/