Skip to content

Fix tests on big endian machines - #427

Merged
jakirkham merged 2 commits into
zarr-developers:masterfrom
QuLogic:test-big-endian
Apr 30, 2019
Merged

jakirkham merged 2 commits into
zarr-developers:masterfrom
QuLogic:test-big-endian

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 2, 2019 •

Copy link
Copy Markdown
Contributor

As in title:

  • Force test arrays to be little-endian.
    These are saved on disk as little-endian and need to be compared as such.
  • Add explicit byteorder on hexdigest tests.

TODO:

  • Add unit tests and/or doctests in docstrings
  • [N/A] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [N/A] New/modified features documented in docs/tutorial.rst
  • [?] Changes documented in docs/release.rst
  • [N/A] Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

QuLogic added 2 commits April 2, 2019 04:37
These are saved on disk as little-endian and need to be compared as
such.

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thoughts @zarr-developers/core-devs?

@jakirkham
jakirkham merged commit adb2e2c into zarr-developers:master Apr 30, 2019
@jakirkham

Copy link
Copy Markdown
Member

Thanks @QuLogic!

@QuLogic
QuLogic deleted the test-big-endian branch May 1, 2019 01:38
@alimanfoo alimanfoo mentioned this pull request May 1, 2019
@jakirkham jakirkham mentioned this pull request May 22, 2019
1 of 7 tasks
@jakirkham

Copy link
Copy Markdown
Member

Have added a changelog entry for this in PR ( #441 ). If you could give that a quick look to make sure everything looks ok, that would be great 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants