Repository navigation
Conversation
jhamman
commented
Jan 7, 2025
| "Please use zarr.buffer and zarr.abc.buffer modules instead.", | ||
| FutureWarning, | ||
| stacklevel=2, | ||
| ) |
Member
Author
There was a problem hiding this comment.
put this in to prompt a discussion -- numcodecs depends on this module already... which sucks.
@normanrz - do you have thoughts on how to proceed? Options are:
- keep
zarr.corebut document it as private. We've managed to do this in the Xarray project with few issues. - change the import in
numcodecsand make a new release
Contributor
There was a problem hiding this comment.
We can easily skip documenting some 'public' (without a _) modules, which would probably help:
Lines 64 to 76 in f9c2024
Member
There was a problem hiding this comment.
I would also lean towards 1. Changing numcodecs would almost certainly also require some backwards-compat shim in zarr-python.
Member
Author
There was a problem hiding this comment.
Alright, let's do that. I'll close this and open a doc-only PR later today.
It's a shame because I quite liked how this shook out. But it is what it is is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
zarr.core.buffertozarr.abc.bufferandzarr.buffer, paving the way to make the rest ofzarr.coreprivate in a follow up PR.Towards #2621