Skip to content

No chunks - #183

Merged
alimanfoo merged 2 commits into
masterfrom
chunks-none
Nov 14, 2017
Merged

No chunks#183
alimanfoo merged 2 commits into
masterfrom
chunks-none

Conversation

@alimanfoo

@alimanfoo alimanfoo commented Nov 14, 2017

Copy link
Copy Markdown
Member

This PR resolves #106. For symmetry and backwards compatibility, I've gone for the following:

  • chunks=True triggers auto-chunking
  • chunks=False means no chunks, i.e., shape of array will be used for value of chunks, i.e., one chunk for whole array
  • chunks=None also triggers auto-chunking for backwards compabitility

@alimanfoo alimanfoo added the in progress Someone is currently working on this label Nov 14, 2017
@alimanfoo alimanfoo added this to the v2.2 milestone Nov 14, 2017
@alimanfoo
alimanfoo merged commit 3688365 into master Nov 14, 2017
@alimanfoo alimanfoo removed the in progress Someone is currently working on this label Nov 14, 2017
@alimanfoo
alimanfoo deleted the chunks-none branch November 14, 2017 23:01
@alimanfoo alimanfoo added enhancement New features or improvements release notes done Automatically applied to PRs which have release notes. labels Nov 20, 2017
@jakirkham jakirkham mentioned this pull request Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New features or improvements release notes done Automatically applied to PRs which have release notes.

Projects

None yet

Milestone

v2.2

Development

Successfully merging this pull request may close these issues.

ENH: chunks=None

1 participant

@alimanfoo