You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
logically, it's array metadata first, and then the version qualifies it. and for consistency: we are already using the X_V2 / X_V3 pattern elsewhere in the codebase to distinguish v2 and v3 metadata representations of comparable things.
Activity
maxrjones commentedon Mar 30, 2026
why?
d-v-b commentedon Mar 30, 2026
logically, it's array metadata first, and then the version qualifies it. and for consistency: we are already using the
X_V2/X_V3pattern elsewhere in the codebase to distinguish v2 and v3 metadata representations of comparable things.maxrjones commentedon Apr 7, 2026
I prefer ArrayMetadataV2 + ArrayMetadataV3; I find the _ is a mixing of naming styles.
https://github.com/zarr-developers/zarr-python/actions/runs/24095500618/job/70292885214?pr=3882 shows other inconsistencies.
d-v-b commentedon Apr 7, 2026
i think we are allowed to mix styles when it favors readability: compare
ArrayMetadataJSON_V3andArrayMetadataJSONV3maxrjones commentedon Apr 7, 2026
Yeah, underscores between distinct sets of capital letters help readability. For the non-JSON class, I prefer ArrayMetadataV3.
We might want to jot down these preferred code styles in the contributors guide or CLAUDE.md