You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The labeler action doesn't seem to be removing "needs release notes" labels when release notes are correclty added to PRs. This should be fixed so when a release note is added, the label is automatically removed.
Not sure if this is an issue with our config, or a bug with the labeler action.
Looks to me like bad configuration. sync-labels is set up appropriately, but the rule currently is to add the label if ANY change is made to a file not in changes/*.rst. Sync can only change things if that condition is voided later, which seems unlikely. We probably want all/all, based on https://github.com/actions/labeler and my now-quite-rusty mastery of syllogistic logic
Activity
moradology commentedon Jan 30, 2025
Looks to me like bad configuration.
sync-labelsis set up appropriately, but the rule currently is to add the label if ANY change is made to a file not inchanges/*.rst. Sync can only change things if that condition is voided later, which seems unlikely. We probably want all/all, based on https://github.com/actions/labeler and my now-quite-rusty mastery of syllogistic logicjhamman commentedon Jan 31, 2025
#2781 seemed to break things...
https://github.com/zarr-developers/zarr-python/actions/runs/13077640517/job/36493605694?pr=2778
jhamman commentedon Jan 31, 2025
Okay, all good now. Thanks @moradology.
Ref showing that this is working on active PRs -> #2778 (comment)