Skip to content

Labeler action doesn't remove "needs release notes" labels #2779

Closed

Description

@dstansby

The labeler action doesn't seem to be removing "needs release notes" labels when release notes are correclty added to PRs. This should be fixed so when a release note is added, the label is automatically removed.

Not sure if this is an issue with our config, or a bug with the labeler action.

Activity

  1. moradology commented on Jan 30, 2025

    @moradology
    Contributor

    Looks to me like bad configuration. sync-labels is set up appropriately, but the rule currently is to add the label if ANY change is made to a file not in changes/*.rst. Sync can only change things if that condition is voided later, which seems unlikely. We probably want all/all, based on https://github.com/actions/labeler and my now-quite-rusty mastery of syllogistic logic

  2. jhamman commented on Jan 31, 2025

    @jhamman
    Member

    Okay, all good now. Thanks @moradology.

    Ref showing that this is working on active PRs -> #2778 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions