Skip to content

Change non-string attribute key from warning to error #1125

Open

Description

@joshmoore

follow-up to #1037 #1066 to perform the breaking change that we were not yet ready to make:

z1.attrs.put({1: "bar", "foo": "bar"})  # Error

Activity

  1. I-am-Emmanuel commented on Oct 12, 2022

    @I-am-Emmanuel

    It will be my pleasure to work on this issue.

  2. I-am-Emmanuel commented on Oct 13, 2022

    @I-am-Emmanuel

    I recently completed this project. Waiting to be merged

  3. sanketverma1704 commented on Oct 13, 2022

    @sanketverma1704
    Member

    Hi @I-am-Emmanuel. Thanks for working on this.
    We'll review your PR #1183.

  4. sanketverma1704 commented on Oct 13, 2022

    @sanketverma1704
    Member

    Hi @I-am-Emmanuel.
    After going through the issue, I realised this issue is a breaking change and needs to be handled by the maintainers for the Zarr python only.
    I think I added the good-first-issue label accidentally, and I sincerely apologise for that. 🙏🏻

    Can you please work on another issue? I'm happy to help you find one if you can't find one.

  5. I-am-Emmanuel commented on Oct 13, 2022

    @I-am-Emmanuel

    Alright

  6. added
    enhancementNew features or improvements
    and removed
    maintenanceWork needed by a maintainer
    on Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew features or improvements

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions