Skip to content

Changed the "level" column in "log" table to be integer again - #5

Merged
samdark merged 2 commits into
yiisoft:masterfrom
Dzhuneyt:132-yii-core-Create_new_migration_for_change_level_column_in_logs_table
Jan 4, 2019
Merged

Changed the "level" column in "log" table to be integer again#5
samdark merged 2 commits into
yiisoft:masterfrom
Dzhuneyt:132-yii-core-Create_new_migration_for_change_level_column_in_logs_table

Conversation

@Dzhuneyt

@Dzhuneyt Dzhuneyt commented Jan 3, 2019

Copy link
Copy Markdown
Contributor
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues https://github.com/yiisoft/yii-core/issues/132

@samdark

samdark commented Jan 3, 2019

Copy link
Copy Markdown
Member

How about making it a single migration? We can do that since there were no package releases yet.

@Dzhuneyt

Dzhuneyt commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

@samdark what about customers that upgrade from an older version of Yii? They will have the old migration already executed and the column type the wrong one.

@samdark

samdark commented Jan 4, 2019

Copy link
Copy Markdown
Member

There is no compatibility guarantee between Yii 2.0 and Yii 3.0. But if you think that two separate migrations are better, I'm fine with it.

@samdark
samdark merged commit 00554d7 into yiisoft:master Jan 4, 2019
@samdark

samdark commented Jan 4, 2019

Copy link
Copy Markdown
Member

Merged. Thanks!

@Dzhuneyt
Dzhuneyt deleted the 132-yii-core-Create_new_migration_for_change_level_column_in_logs_table branch January 4, 2019 15:14
@Dzhuneyt

Dzhuneyt commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

There is no compatibility guarantee between Yii 2.0 and Yii 3.0. But if you think that two separate migrations are better, I'm fine with it.

I have bad experiencing changing old migrations' code for ANY reason in my day job. That's all :)

@Dzhuneyt

Dzhuneyt commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

@samdark just out of curiousity, now that a lot of functionalities have been moved outside of the yii-core project into their own dedicated projects - will they all have their own CHANGELOG file (I see this one doesn't, for example).

@samdark

samdark commented Jan 4, 2019

Copy link
Copy Markdown
Member

Yes. After first release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants