Skip to content

Per-node kernel arguments for the installed OS - #392

Merged
jjohnson42 merged 2 commits into
xcat2:masterfrom
Obihoernchen:feat/node-installedargs
Nov 18, 2026
Merged

jjohnson42 merged 2 commits into
xcat2:masterfrom
Obihoernchen:feat/node-installedargs

Conversation

@Obihoernchen

@Obihoernchen Obihoernchen commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Adds deployment.installedargs, appended after the profile installedargs in the bootloader configuration of the installed system. It reaches the node through deploycfg.

Diskless images installed to disk (installtodisk) now also apply the profile installedargs, which were ignored on that path before. An argument the image already has is kept once, so captured images do not accumulate copies.

Profile installedargs deployment.installedargs Installed kernel command line
(unset) (unset) distribution defaults
crashkernel=1G (unset) ... crashkernel=1G
crashkernel=1G nohz_full=4-63 ... crashkernel=1G nohz_full=4-63
panic=5 panic=30 ... panic=5 panic=30 (node wins)
Deployment Where it is written
Stateful EL, RHVH kickstart bootloader --append
Stateful SUSE 15 / 16 AutoYaST <append> / Agama extraKernelParams
Stateful Debian, Ubuntu GRUB_CMDLINE_LINUX
installtodisk EL8, Ubuntu GRUB_CMDLINE_LINUX
installtodisk EL9, EL10 GRUB_CMDLINE_LINUX, /etc/kernel/cmdline, boot loader entries
Stateless not applicable

Characters GRUB treats specially (&, ;, |, <, >, $, quotes) are not supported. For network boot arguments see #391.

Tested on EL9, EL10, Ubuntu 24.04, Ubuntu 26.04 and Leap 16.

@jjohnson42

Copy link
Copy Markdown
Member

ok, take care of the attribute.py conflict now

Kernel arguments for the installed OS could only be set per profile,
with installedargs in profile.yaml. deployment.installedargs sets them
per node or group, appended after the ones of the profile.

The deploycfg served to the node carries the value as installedargs,
and the installers add it wherever they add the profile installedargs:
the kickstart bootloader line on EL and RHVH, the AutoYaST and Agama
bootloader settings on SUSE, and GRUB_CMDLINE_LINUX on Debian and
Ubuntu. Diskless images installed to disk add it to GRUB_CMDLINE_LINUX,
and on EL9 and EL10 also to /etc/kernel/cmdline and the boot loader
entries.

deploycfg is no longer wrapped at 80 columns, since the scripts read
each value from its single line.
The installedargs of profile.yaml only reached systems installed by an
OS installer. A diskless image written to disk with installtodisk got
none of them, and keeps from the network boot only console=,
net.ifnames=, biosdevname= and quiet, so arguments meant for the
installed system had to be baked into the image.

image2disk.py now fetches the profile.yaml of the deployment and adds
its installedargs before deployment.installedargs, in the same places.
An argument the image already has, as when it was captured from a node
installed this way, is kept once, in its last position, so the node
arguments still come last, and a profile.yaml that cannot be read only
skips the profile arguments instead of failing the install.
@Obihoernchen
Obihoernchen force-pushed the feat/node-installedargs branch from f6f5dae to d4bea73 Compare November 18, 2026 22:44
@jjohnson42
jjohnson42 merged commit 2e958be into xcat2:master Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants