-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Add NOT_GIVEN sentinel for nullable optional params #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| from workos._types import NOT_GIVEN, NotGiven | ||
|
|
||
|
|
||
| class TestNotGiven: | ||
| """The NOT_GIVEN sentinel is the default for nullable optional params, | ||
| letting generated methods tell an omitted argument apart from an explicit | ||
| None (which clears the field via JSON null).""" | ||
|
|
||
| def test_is_falsy(self): | ||
| assert not NOT_GIVEN | ||
| assert bool(NOT_GIVEN) is False | ||
|
|
||
| def test_repr(self): | ||
| assert repr(NOT_GIVEN) == "NOT_GIVEN" | ||
|
|
||
| def test_is_distinct_from_none(self): | ||
| assert NOT_GIVEN is not None | ||
| assert isinstance(NOT_GIVEN, NotGiven) | ||
|
|
||
| def test_exported_from_public_namespace(self): | ||
| import workos | ||
|
|
||
| assert workos.NOT_GIVEN is NOT_GIVEN | ||
| assert workos.NotGiven is NotGiven |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.