-
Notifications
You must be signed in to change notification settings - Fork 32
feat(generated): AuditLogs (batch 56391ebd) #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| * [#690](https://github.com/workos/workos-python/pull/690) fix(generated): regenerate from spec | ||
|
|
||
| **Features** | ||
| * **[audit_logs](https://workos.com/docs/reference/audit-logs)**: | ||
| * Added `expired` to `AuditLogExportState` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 23faa38318d596e581656934ed72c4a18476d742 | ||
| 56a015eaa3c5fb42a7dd77526c43953a971f4907 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| # This file is auto-generated by oagen. Do not edit. | ||
|
|
||
| from .connection import Connection as Connection | ||
| from .connection_option import * # noqa: F401,F403 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/workos/sso/models/__init__.py
Line: 4
Comment:
**Wildcard import without `__all__` leaks stdlib names into `workos.sso.models`**
`connection_option.py` has no `__all__`, so `from .connection_option import *` exports `ConnectionOption` plus `dataclass`, `Any`, `Dict`, and `Optional` into the `workos.sso.models` namespace. Defining `__all__ = ["ConnectionOption"]` in `connection_option.py` would match the contained pattern already used by `data_integration_credentials_type.py` and avoid unexpected names appearing in the public interface.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| from .connection_domain import ConnectionDomain as ConnectionDomain | ||
| from .connection_option import ConnectionOption as ConnectionOption | ||
| from .connections_connection_type import ( | ||
| ConnectionsConnectionType as ConnectionsConnectionType, | ||
| ) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__all__pollute module namespaceconnected_account_dto.pyanddata_integration_credentials_dto.pydo not define__all__, sofrom .connected_account_dto import *andfrom .data_integration_credentials_dto import *will export every public name in those files — includingEnum,datetime,dataclass,Any,Dict,List,Optional,ConnectedAccountState, andDataIntegrationCredentialsType— intoworkos.pipes.models. Any downstreamfrom workos.pipes.models import *would then unexpectedly pick up these typing/stdlib names. Adding__all__ = ["ConnectedAccountDto"](and similarly for the DTO) to the source files would scope the export correctly, matching the approach already used bydata_integration_credentials_type.py.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!