Skip to content

Adapt gdown to be used as python library - #244

Closed
Skitionek wants to merge 1 commit into
wkentaro:mainfrom
Skitionek:main
Closed

Skitionek wants to merge 1 commit into
wkentaro:mainfrom
Skitionek:main

Conversation

@Skitionek

@Skitionek Skitionek commented Feb 20, 2023 •

Copy link
Copy Markdown

Summary

  • Exceptions are printed only on cli (otherwise simply raised)
  • Allows for custom progress callbacks (which defaults to old behaviour)
  • stderr stands for "standard error" - progress messages should be printed to stdin

@wkentaro

Copy link
Copy Markdown
Owner

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

@wkentaro

Copy link
Copy Markdown
Owner

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

image

@Skitionek

Copy link
Copy Markdown
Author

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

image

Interesting, yet putting flag --quiet should silence all progress prints from code.... Therefore it still can be used the way you mentioned.

@Skitionek

Copy link
Copy Markdown
Author

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

Moved Exceptions to separate PR: #246

@wkentaro

Copy link
Copy Markdown
Owner

Closing this — it's been open for 3+ years and the codebase has diverged significantly. The exception handling part was already split into #246. Thanks for the contribution though.

@wkentaro wkentaro closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants