Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Copyright © WireMock.Net

using System.Linq;
using Stef.Validation;
using WireMock.Types;

Expand Down Expand Up @@ -54,7 +53,10 @@ public RequestMessageParamMatcher(MatchBehaviour matchBehaviour, string key, boo
/// <param name="ignoreCase">Defines if the key should be matched using case-ignore.</param>
/// <param name="values">The values.</param>
public RequestMessageParamMatcher(MatchBehaviour matchBehaviour, string key, bool ignoreCase, params string[]? values) :
this(matchBehaviour, key, ignoreCase, values?.Select(value => new ExactMatcher(matchBehaviour, ignoreCase, MatchOperator.And, value)).Cast<IStringMatcher>().ToArray())
// Note: the inner ExactMatcher must use AcceptOnMatch.
// The MatchBehaviour (e.g. RejectOnMatch) is applied once by this matcher's GetMatchingScore.
// Passing matchBehaviour here as well would apply the conversion twice and invert RejectOnMatch.
this(matchBehaviour, key, ignoreCase, values?.Select(value => new ExactMatcher(MatchBehaviour.AcceptOnMatch, ignoreCase, MatchOperator.And, value)).Cast<IStringMatcher>().ToArray())
{
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,5 +209,79 @@ public void RequestMessageParamMatcher_With1ParamContainingComma_Using_QueryPara
// Assert
score.Should().Be(1.0);
}
}

[Fact]
public void RequestMessageParamMatcher_RejectOnMatch_WhenValuePresentMatchesPattern_ReturnsMismatch()
{
// Assign: the param value in the URL matches the reject pattern -> the mapping must be rejected (score 0.0).
var requestMessage = new RequestMessage(new UrlDetails("http://localhost?key=abc"), "GET", "127.0.0.1");
var matcher = new RequestMessageParamMatcher(MatchBehaviour.RejectOnMatch, "key", false, new[] { "abc" });

// Act
var result = new RequestMatchResult();
var score = matcher.GetMatchingScore(requestMessage, result);

// Assert
score.Should().Be(0.0d);
}

[Fact]
public void RequestMessageParamMatcher_RejectOnMatch_WhenValuePresentDoesNotMatchPattern_ReturnsPerfect()
{
// Assign: the param value in the URL does NOT match the reject pattern -> the mapping is accepted (score 1.0).
var requestMessage = new RequestMessage(new UrlDetails("http://localhost?key=xyz"), "GET", "127.0.0.1");
var matcher = new RequestMessageParamMatcher(MatchBehaviour.RejectOnMatch, "key", false, new[] { "abc" });

// Act
var result = new RequestMatchResult();
var score = matcher.GetMatchingScore(requestMessage, result);

// Assert
score.Should().Be(1.0d);
}

[Fact]
public void RequestMessageParamMatcher_RejectOnMatch_WithIgnoreCase_WhenValueMatchesCaseInsensitively_ReturnsMismatch()
{
// Assign: ignoreCase must still be honored on the inner matcher after the fix.
var requestMessage = new RequestMessage(new UrlDetails("http://localhost?key=ABC"), "GET", "127.0.0.1");
var matcher = new RequestMessageParamMatcher(MatchBehaviour.RejectOnMatch, "key", true, new[] { "abc" });

// Act
var result = new RequestMatchResult();
var score = matcher.GetMatchingScore(requestMessage, result);

// Assert
score.Should().Be(0.0d);
}

[Fact]
public void RequestMessageParamMatcher_AcceptOnMatch_WhenValuePresentMatchesPattern_ReturnsPerfect()
{
// Assign
var requestMessage = new RequestMessage(new UrlDetails("http://localhost?key=abc"), "GET", "127.0.0.1");
var matcher = new RequestMessageParamMatcher(MatchBehaviour.AcceptOnMatch, "key", false, new[] { "abc" });

// Act
var result = new RequestMatchResult();
var score = matcher.GetMatchingScore(requestMessage, result);

// Assert
score.Should().Be(1.0d);
}

[Fact]
public void RequestMessageParamMatcher_AcceptOnMatch_WhenValuePresentDoesNotMatchPattern_ReturnsMismatch()
{
// Assign
var requestMessage = new RequestMessage(new UrlDetails("http://localhost?key=xyz"), "GET", "127.0.0.1");
var matcher = new RequestMessageParamMatcher(MatchBehaviour.AcceptOnMatch, "key", false, new[] { "abc" });

// Act
var result = new RequestMatchResult();
var score = matcher.GetMatchingScore(requestMessage, result);

// Assert
score.Should().Be(0.0d);
}
}
48 changes: 48 additions & 0 deletions test/WireMock.Net.Tests/WireMockServerTests.WithParam.cs
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,54 @@ public async Task WireMockServer_WithParam_RejectOnMatch_OnNonMatchingParam_Shou
server.Stop();
}

[Fact]
public async Task WireMockServer_WithParam_RejectOnMatch_WithValue_WhenValueMatches_ShouldNotMatch_Returns404()
{
// Arrange
var cancelationToken = TestContext.Current.CancellationToken;
var server = WireMockServer.Start();
server.Given(
Request.Create()
.WithPath("/x")
.WithParam("k", MatchBehaviour.RejectOnMatch, "abc")
.UsingGet()
)
.ThenRespondWithOK();

// Act
var requestUri = new Uri($"http://localhost:{server.Port}/x?k=abc");
var response = await server.CreateClient().GetAsync(requestUri, cancelationToken);

// Assert
response.StatusCode.Should().Be(HttpStatusCode.NotFound);

server.Stop();
}

[Fact]
public async Task WireMockServer_WithParam_RejectOnMatch_WithValue_WhenValueDoesNotMatch_ShouldMatch_Returns200()
{
// Arrange
var cancelationToken = TestContext.Current.CancellationToken;
var server = WireMockServer.Start();
server.Given(
Request.Create()
.WithPath("/x")
.WithParam("k", MatchBehaviour.RejectOnMatch, "abc")
.UsingGet()
)
.ThenRespondWithOK();

// Act
var requestUri = new Uri($"http://localhost:{server.Port}/x?k=xyz");
var response = await server.CreateClient().GetAsync(requestUri, cancelationToken);

// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);

server.Stop();
}

[Fact]
public async Task WireMockServer_WithParam_AcceptOnMatch_OnNonMatchingParam_ShouldReturnMappingOk()
{
Expand Down
Loading