[TaoYe599]

Summary

Two small, related fixes so the headless-Chrome QA toolchain (capture, drive, turn-check) runs on Windows. Both patches are no-ops on POSIX behavior-wise, and the full startup test suite passes 3/3 on Windows 11 (10.0.26100), Node v24.19.0.

Patch 1 — scripts/chrome-port.mjs: retry profile cleanup so a transient EPERM does not mask the real error

First principles. On Windows, a file cannot be deleted while any process holds an open handle to it. When Chrome fails to start and is killed with SIGKILL, kernel handle teardown is asynchronous: the dying child's handles to its --user-data-dir profile files can briefly outlive the kill. The current cleanup does a single synchronous unlink:

rmSync(profile, { recursive: true, force: true });

A sharing violation (EPERM) on any profile file at that instant makes rmSync throw inside the catch block — the block whose entire job is to surface the real diagnostic (Chrome exited before startup: ...). The caller then sees a misleading EPERM instead of the actual cause, breaking the error contract that chrome-startup.test.mjs itself asserts on (/Chrome exited before startup/).

Why the fix is principled rather than a workaround. Node's fs.rm already implements exactly this semantics — maxRetries/retryDelay exist primarily because Windows sharing violations are a documented, transient filesystem behavior — so the patch simply opts into the platform-appropriate API:

await rm(profile, { recursive: true, force: true, maxRetries: 12, retryDelay: 150 });

~1.8 s worst case, only spent when an EPERM-class error actually occurs; the POSIX happy path is unaffected. If cleanup still fails, both errors are wrapped in an AggregateError ("Chrome startup and profile cleanup both failed") so the original startup error is never lost — the diagnostic contract is preserved even in the worst case.

Patch 2 — scripts/chrome-startup.test.mjs: make the fake-Chrome shim work on Windows

First principles. The test fabricates a chrome binary as a #!/bin/sh shell script with chmod 0o755. On Windows there is no /bin/sh, so spawning the shim fails before any launcher logic runs — the test never reaches the cleanup path it exists to verify. It's not that the test fails loudly; it fails in a way that tells you nothing about profile cleanup.

Fix. On win32, use process.execPath (Node itself) as the early-exit Chrome substitute: Node is always present, requires no new dependency, and invoking it with Chrome's arguments guarantees an immediate non-listening exit, exercising the same "Chrome exited before startup" cleanup path. Cleanup is then verified directly — snapshot the iso-capture- / iso-drive- / turn-check- prefixed temp profile directories before and after, and assert none leak. The POSIX path (shim script + receipt file) is kept byte-for-byte and remains the code path used on macOS/Linux.

Testing

• Windows 11 (10.0.26100 x64), Node v24.19.0: node --test scripts/chrome-startup.test.mjs → 3/3 pass (~1.3 s).
• Patch applies cleanly on top of 1482e84 (current main).
• No behavior change on POSIX: same APIs are called, retries only activate on EPERM-class errors that essentially do not occur here, and the shim path is untouched.