Fix demo auth privilege escalation and approval attribution - #8
Open
wesmacdonald wants to merge 1 commit into
Open
wesmacdonald wants to merge 1 commit into
wesmacdonald wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -203,7 +197,7 @@ public async Task<IActionResult> ApproveWorkflow( | |||
| /// Only SecurityReviewer role is authorized. | |||
| { | ||
| reviewer = User.FindFirstValue(ClaimTypes.NameIdentifier) ?? User.Identity?.Name ?? string.Empty; | ||
| reviewerRole = User.FindFirstValue(ClaimTypes.Role) ?? string.Empty; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo API defaults previously allowed a well-known bearer token and caller-selected role headers, while approval records trusted reviewer identity from the request body. These defaults could expose privileged actions and undermine audit attribution.
This change requires explicitly configured demo tokens with fixed Developer and SecurityReviewer roles, binds the Compose port to loopback, and derives approval/rejection identity and role from authenticated claims. It also adds regression tests and upgrades Microsoft.Identity.Web to 4.16.0 to remove a high-severity transitive dependency advisory.
Validation: 77 tests passed, 2 optional integration tests skipped; Docker Compose configuration validated; NuGet vulnerability scan reports no vulnerable packages.