Repository navigation
fix(skills-index): allowlist kwh/kya/vrfy with ontology reasons #116
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,5 +6,26 @@ | |||||
| "pricing.model": "free", | ||||||
| "auth.scope": null | ||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| "name": "kwh", | ||||||
| "justification": "KWH issues metering and signed receipts for active agent work (ontology domains/kwh; ruling documents/d-domain-rulings-oct9). Probed 2026-10-09 6:59 PM ET: every /v1/kwh, GET and POST, on gateway.wave.online answers 503 SPOKE_NOT_LIVE, so there is no served operation to document yet. Add real operations when the KWH spoke has a live origin. Honored only while the index carries no meter.", | ||||||
| "expect": { | ||||||
| "pricing.meter": null | ||||||
|
There was a problem hiding this comment. P2: These exemptions persist after KYA/VRFY become live: both are described as free forever, while the only predicate is Prompt for AI agents |
||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| "name": "kya", | ||||||
| "justification": "KYA is identity: a public, stranger-checkable agent record, free forever (ontology domains/kya; documents/d-kya-k7-free-with-enterprise). The served free identity op is already documented as identityResolve (/identity/resolve). Probed 2026-10-09 6:59 PM ET: every /v1/kya, GET and POST, on gateway.wave.online answers 503 SPOKE_NOT_LIVE, so there is no served operation to document yet. Honored only while the index carries no meter.", | ||||||
|
There was a problem hiding this comment. Suggestion: Remove the free-forever claim and plan reference, and explain the exemption using only the endpoint's unavailable status. Severity Level: Major Rule source 📖CodeAnt dashboard (rule "rules-1790440327969-5ltphbdub")
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** .github/scripts/skills-index-allowlist.json
**Line:** 19:19
**Comment:**
*Custom Rule: Remove the free-forever claim and plan reference, and explain the exemption using only the endpoint's unavailable status.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fixThere was a problem hiding this comment. P2: Remove the free-forever claim and enterprise-plan reference from this public justification; state only that the endpoint is unavailable. Prompt for AI agents
Suggested change
|
||||||
| "expect": { | ||||||
| "pricing.meter": null | ||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| "name": "vrfy", | ||||||
| "justification": "VRFY only checks receipts and is free forever, with no persistence (ontology domains/vrfy; Orchestrator ruling Oct 9). It issues nothing, so it has no priced operation. Probed 2026-10-09 6:59 PM ET: every /v1/vrfy, GET and POST, on gateway.wave.online answers 503 SPOKE_NOT_LIVE, so there is no served operation to document yet. Honored only while the index carries no meter.", | ||||||
| "expect": { | ||||||
| "pricing.meter": null | ||||||
| } | ||||||
|
Comment on lines
+27
to
+29
There was a problem hiding this comment. Suggestion: For Assessment: 🟠
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** .github/scripts/skills-index-allowlist.json
**Line:** 27:29
**Comment:**
*Incorrect Condition Logic: For `kya` and `vrfy`, the spokes can become live while `pricing.meter` stays null, so this predicate keeps bypassing coverage for undocumented operations.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix |
||||||
| } | ||||||
| ] | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Rewrite this public allowlist justification to describe the unavailable endpoint without disclosing metering or other pricing details.
Severity Level: Major⚠️ · 🏷️
Custom_ruleRule source 📖
CodeAnt dashboard (rule "rules-1790440327969-5ltphbdub")
Prompt for AI Agent 🤖