Skip to content

chore(ci): remove unused reviewer integrations from the review floor - #108

Draft
yakimoto wants to merge 2 commits into
mainfrom
chore/drop-retired-vendors
Draft

yakimoto wants to merge 2 commits into
mainfrom
chore/drop-retired-vendors

Conversation

@yakimoto

@yakimoto yakimoto commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

User description

What

Removes unused reviewer integrations from the review-liveness floor in .github/workflows/auto-merge.yml.

The floor counts DISTINCT external review publishers that finished non-failing on the PR head, matched by the LLM_RE pattern. Two names in that pattern belong to reviewer integrations that no longer report on this repository, and one belongs to a hosted service that is not used here (the self-hosted pr-agent lane runs as a github-actions job, which the floor already excludes by design, so it is unaffected). This PR drops those three names from LLM_RE. cubic stays in the pattern. Nothing else in the workflow changes.

Why this is safe: the floor stays satisfiable

The floor defaults to MIN_REVIEWERS=2 distinct publishers. I checked the check-runs and commit statuses on recent PR heads in this repository. The reviewers that still report there, and that still match the pattern after this change, are:

  • cursor check-runs (success/neutral both count)
  • macroscopeapp check-runs (Approvability Check, neutral)
  • sourcery-ai check-runs (success on most PRs)
  • CodeRabbit and Devin commit statuses (these carry no creator login, so together they count as one publisher)

That leaves at least two distinct publishers on a typical PR, so the floor can still be met. The floor itself, the threshold and the defer/refuse logic are untouched. Removing names from the pattern can only make the floor stricter, never looser.

Verification

  • actionlint on the changed workflow file(s): clean (exit 0)
  • Repo lint and tests: npm run lint (redocly): valid, with 58 pre-existing warnings; npm run test:ga 35 passed / 0 failed. The change is workflow-only, so these are regression receipts rather than coverage of the change.
  • Self-reviewed diff: a one-line regex change only

Not in scope

  • Historical comments in scripts and tests that credit past review feedback are left alone, because they record what happened and are not wrong about current behaviour.
  • The self-hosted pr-agent workflow is intentionally kept.

Draft. Do not merge until a maintainer has reviewed it.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by Sourcery

Enhancements:

  • Update the auto-merge review-liveness floor to recognize only active reviewer integrations.

Review in cubic


CodeAnt-AI Description

Remove retired reviewer integrations from the auto-merge review floor

What Changed

  • The auto-merge review-liveness check no longer counts retired reviewer integrations or unused vendors.
  • The existing reviewer threshold and defer behavior remain unchanged, so only currently reporting external reviewers can satisfy the floor.

Impact

✅ Prevents inactive reviewers from satisfying merge requirements
✅ Keeps auto-merge checks aligned with active review providers

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Drop reviewer names that no longer report on this repository from the
auto-merge review-liveness pattern. The floor (default 2 distinct
publishers) remains satisfiable by the reviewers that still report on HEAD.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8c334759-d0c2-45c7-a7d9-2b489bfe3952

📥 Commits

Reviewing files that changed from the base of the PR and between 3bed828 and 63d7e90.

📒 Files selected for processing (1)
  • .github/workflows/auto-merge.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.github/workflows/auto-merge.yml (1)

199-199: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated review checks so fewer review sources count toward the minimum review activity requirement.

Walkthrough

The auto-merge workflow’s LLM reviewer-name pattern no longer includes greptile, gitar, or qodo. Runs matching those names no longer count toward the review-liveness floor.

Changes

Reviewer Matching

Layer / File(s) Summary
Update reviewer-name pattern
.github/workflows/auto-merge.yml
The LLM reviewer-name pattern removes greptile, gitar, and qodo.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 63d7e

This change excludes three reviewer names from the review floor. No available evidence establishes that they are needed to meet the minimum, so a concrete auto-merge blockage is not established.

Architecture Summary

Architecture risk: 🔵 Low · up to 63d7e

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/auto-merge.yml: The LLM_RE reviewer-name pattern removes greptile, gitar, and qodo, so runs matching those names no longer count toward the LLM reviewer floor.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the workflow change: removing unused reviewer integrations from the review floor.
Description check ✅ Passed The description directly explains the removal of inactive reviewer integrations, the unchanged threshold and logic, and the verification performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This workflow-only change removes four unused reviewer integrations from the review-liveness regex, while preserving the existing floor threshold and enforcement logic. Reviewers should confirm the removed names are no longer expected to report and that the remaining publishers continue to provide enough distinct non-failing reviews to satisfy the default floor.

File-Level Changes

Change Details Files
Remove obsolete and unused reviewer publishers from the review-liveness matching pattern.
  • Delete four inactive integration names from LLM_RE.
  • Retain currently reporting publishers and the intentionally excluded self-hosted github-actions lane.
.github/workflows/auto-merge.yml
Keep the review floor’s enforcement behavior unchanged while narrowing which publishers can satisfy it.
  • Leave the minimum threshold, distinct-publisher counting, status handling, and defer/refuse logic untouched.
  • Verify the remaining integrations can still satisfy the default two-reviewer floor.
.github/workflows/auto-merge.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/auto-merge.yml Resolved
Comment thread .github/workflows/auto-merge.yml Resolved
@wave-bugbot

wave-bugbot Bot commented Sep 26, 2026

Copy link
Copy Markdown

🟢 WAVE BugBot — clear

No confident findings on the changed lines.

Local review · $0 inference · wave-dispatch

@yakimoto

Copy link
Copy Markdown
Contributor Author

@CodeAnt-AI: review

@codeant-ai

codeant-ai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 29a9f3d Sep 26, 2026 · 14:32 14:33

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Sep 26, 2026
Comment thread .github/workflows/auto-merge.yml Resolved
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@yakimoto

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant