Spec: Keep window open after closing the last tab (APP-5230) - #14824
Draft
warp-agent-staging[bot] wants to merge 2 commits into
Draft
Spec: Keep window open after closing the last tab (APP-5230)#14824warp-agent-staging[bot] wants to merge 2 commits into
warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Warp Agent <agent@warp.dev>
Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defines the product and technical contract for making final-tab window closing configurable. The revised spec makes the replacement active-tab invariant explicit as
Option<usize>, audits 267 non-test invariant locations across 159 functions, specifies safe behavior by call-site class, raises the true zero-tab variant to L (5), and contrasts it with APP-5242's lower-risk fresh-tab approach. It also covers settings and command-palette surfaces, confirmation ownership, CloseWindow-disabled hosts, persistence, recovery paths, and the intentionally asymmetric single-tab drag behavior.This draft PR will carry the implementation after the spec is approved.
Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1786043046497489
Linked Issue
APP-5230
Testing
./script/format --checkScreenshots / Videos
Not applicable to this spec-only commit. Implementation must attach the required visual proof before this PR is marked ready.
Agent Mode
Co-Authored-By: Warp Agent agent@warp.dev
Conversation: https://staging.warp.dev/conversation/dfbf2c3d-65c2-432b-ba26-9e3384f53e81
Run: https://oz.staging.warp.dev/runs/019fdc72-0204-7987-ab2f-1b286324f7e5
This PR was generated with Oz.