Skip to content

correct typedef of Route - #3901

Open
aryanbhosale wants to merge 2 commits into
vuejs:devfrom
aryanbhosale:patch-1
Open

correct typedef of Route#3901
aryanbhosale wants to merge 2 commits into
vuejs:devfrom
aryanbhosale:patch-1

Conversation

@aryanbhosale

Copy link
Copy Markdown

Fixes #3566

updated typedef of interface Route from query: Dictionary<string | (string | null)[]> to query: Dictionary<string | null | (string | null)[]>

@netlify

netlify Bot commented Aug 25, 2024

Copy link
Copy Markdown

Deploy Preview for vue-router-docs-v3 canceled.

Name Link
🔨 Latest commit dee25cf
🔍 Latest deploy log https://app.netlify.com/sites/vue-router-docs-v3/deploys/66cdaf9e95579c000874784d

@posva posva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@aryanbhosale

Copy link
Copy Markdown
Author

Can you add a test?

Which files exactly? im kinda new to this so just the files that need to be covered would be great

@posva

posva commented Aug 26, 2024

Copy link
Copy Markdown
Member

@aryanbhosale

Copy link
Copy Markdown
Author

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

Thank you! Will have a look

@aryanbhosale

Copy link
Copy Markdown
Author

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

is my latest commit what you were looking for in the test?

@posva

posva commented Aug 28, 2024

Copy link
Copy Markdown
Member

Thanks! That should be the test. I will take a look on my next pass over vue router 3.

@aryanbhosale
aryanbhosale requested a review from posva August 28, 2024 06:34
@yash-dayama

Copy link
Copy Markdown

I have updated the code after reading all the comments can you please check this @posva

@posva

posva commented Jul 31, 2025

Copy link
Copy Markdown
Member

This is the old non maintained version of Vue router. I only do paid reviews and release for companies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The type definition of Route seems to be partially wrong

3 participants