fix(css): preserve dollar signs in external @import urls with lightningcss - #22718
Merged
sapphi-red merged 2 commits intoJun 30, 2026
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the lightningcss transformer, an external
@importURL containing$could be corrupted in the output.Problem
importcase usedcss.replace(dep.placeholder, dep.url)withdep.urlas a replacement string.$&,$`,$',$n,$$are special patterns. So a URL likehttps://cdn.example.com/a.css?q=$&gets mangled —$&is expanded to the matched placeholder text instead of being inserted verbatim.urlcase already guards against this with a function replacer; theimportcase did not.Fix
() => dep.url) so the URL is inserted literally, with no replacement-pattern interpretation.Tests
preprocessCSStest using the lightningcss transformer with an external@importURL containing$&. It fails without this change (the URL is mangled) and passes with it.