fix(ssr): ssrTransform incorrectly rewrites meta identifier inside import.meta when a binding named meta exists - #22019
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an imported binding was named
meta,ssrTransformwould incorrectly replace themetainimport.metawith the import binding accessor, corrupting the output.Root Cause
isRefIdentifierhad no guard forMetaPropertyparent nodes. Themetaidentifier inimport.metahas aMetaPropertyparent, but the function only excludedMemberExpressionnon-computed properties — sometawas treated as a rewritable reference.Fix
MetaPropertyparent check toisRefIdentifier, returningfalseto prevent rewriting identifiers that are part ofimport.meta.Original prompt
ssrTransformfails to transformimport.metawhen there is imported variable namedmeta#22004💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.