Repository navigation
Fix review findings in MCP tools and --json output - #63
Merged
Merged
Conversation
MCP (#58): - Read-only runs no longer start configured MCP servers. - mcp_servers in the config no longer blocks --resume of built-in checkpoints; the servers are skipped instead. - Accept common SDK-generated schemas: drop a top-level $schema, allow nullable type arrays and standard validation/annotation keywords. - A call timeout or interrupt no longer disables the server for the rest of the run; only connection failures do. - ExternalCall reports failures with an explicit flag instead of matching "error: " / "tool error: " prefixes. - Move per-server startup into one function: drop checks duplicated from validateDefinitions, the unreachable reserved-name check, and the deferred cancel inside the loop. - Drop the wall-clock recomputation after discovery; the deadline set before discovery already bounds the run and ends as TimeLimitExceeded. --json (#61): - Share run.started/result emission between fresh and resumed runs. - Test a full run's event stream end to end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #58 and #61, fixing issues found reviewing them after merge.
MCP tools (#58)
mcp_serversno longer blocks--resume. Any MCP config used to make every resume fail; built-in checkpoints now resume and the servers are skipped with a note. MCP-enabled checkpoints are still rejected.$schemais dropped, nullable["string","null"]types and standard keywords (format,pattern,const, exclusive bounds,multipleOf,uniqueItems,examples, …) are allowed.anyOf/oneOf/allOfand refs are still rejected.ExternalCallnow returnsisErrinstead oftool.result.is_errorbeing inferred from output prefixes.deferin a loop). The wall-clock recomputation after discovery is gone: the deadline set before discovery already bounds the run, and an exhausted budget now ends asTimeLimitExceededinstead of a generic exit-1 error.--json(#61)startEvents/jsonEvents.finishreplace the event setup duplicated across fresh and resumed runs.run.started…result, nothing else on stdout).Verification
go build ./...,go vet ./...,gofmt -l .,go test -count=1 ./...,git diff --checkanyOfrejected,isErrorflagged, timeout keeps the server usable (confirmed failing against the old behavior)TimeLimitExceeded🤖 Generated with Claude Code