Repository navigation
test(recovery): simplify byte encoding in signed child fixtures - #5262
Conversation
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|



The managed-recovery crash fixture removes base64 padding with a regex that Sonar Cloud flags for backtracking. Replace it with literal padding removal and use code-point conversion for the byte-only DER/base64 inputs in both recovery child fixtures. Uint8Array bounds every converted value to 0..255, and btoa emits equals signs only as padding, so the encoded keys, hashes, and signatures stay byte-identical.
This focused reliability batch targets four Cloud findings. Full-file local analysis reduces from 9 to 6 by clearing three byte-conversion findings; its profile does not report the Cloud regex rule. No new local issues or suppressions. Remaining async callbacks retain their promise contract and rejection behavior.
Validation:
Production code and recovery scheduling are unchanged. The HTTP/PostgreSQL crash scenario was not run locally; encoding equivalence and the owner subprocess are verified here. All current-commit CI workflows pass. Sonar Cloud quality gate passes with zero new open issues and 0.0% new duplication.