Repository navigation
refactor(build): simplify npm graph and contract validation - #5261
Conversation
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|



The npm build validators combine selector resolution, module graph traversal, package-root import classification, and AST walking inside complex functions. Extract private validation phases for declaration references, binding collection, conditional/member/URL selectors, reference collection, entry-point and target validation, unreachable-directory removal, runtime helper checks, and meta-property child traversal. Clarify two small expression/regex decisions.
Preserve conservative uncertain-graph handling, declaration-file fallback, package containment, reference and diagnostic order, helper accounting, parse-failure rejection, and sequential filesystem operations. Directory deletion still starts only after the graph is complete.
Validation:
The original direct Deno.stat await remains inside the import loop; synchronous failure recording preserves missing-file handling. All current-commit CI workflows pass. Sonar Cloud quality gate passes with zero new open issues and 0.0% new duplication.
Public APIs are unchanged.