Repository navigation
Scope project env overlays in sandbox workers - #2171
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cd39e6dd1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Long-lived project workers previously applied per-request projectEnv overlays directly to Deno.env without restoring prior values. That let one tenant request leave env values visible to later requests handled by the same worker. The worker script now scopes overlay keys through a snapshot/restore helper used by app and pages route execution, and real-worker tests cover unknown request errors plus env overlay isolation. Constraint: Project workers are reused across requests, so projectEnv must be request-scoped even though Deno.env is process-like inside the worker. Rejected: Creating a separate worker per request | too expensive and contrary to the pool design. Confidence: high Scope-risk: narrow Directive: Do not write projectEnv directly to Deno.env in worker handlers without restoring it in a finally block. Tested: deno test --no-check --allow-all --unstable-worker-options src/security/sandbox/project-worker.test.ts Tested: deno test --no-check --allow-all src/utils/version.test.ts Tested: deno check src/security/sandbox/worker-script.ts src/security/sandbox/project-worker.test.ts src/utils/version-constant.ts src/utils/version.ts src/utils/version.test.ts Tested: deno task verify:quick
kojiwakayama
force-pushed
the
fix/sandbox-env-overlay-scope
branch
from
June 9, 2026 08:23
4cd39e6 to
e4fc37e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Refs #1989