Repository navigation
fix(kde): tint panel icon by battery level and unbreak the Lighting page - #16
Merged
Merged
Conversation
Three fixes for issues reported on a live Plasma 6 session:
- The panel icon never changed color: input-gaming-symbolic is a GNOME
icon name. Breeze doesn't have it and silently falls back to the
full-color input-gaming, which cannot be recolored. Use Breeze's
input-gamepad-symbolic (falling back to input-gaming-symbolic on
GNOME icon themes) and set isMask so Kirigami applies the tint
regardless of theme. Verified with a grabToImage pixel test on
Kirigami 6.17: color alone does not tint, color + isMask does.
- The Lighting config page failed to load ("Component is not ready"):
Qt 6 ColorDialog is not an Item and has no parent property, so
`parent: page` aborted creation of the whole page. Reproduced the
exact journal error in a qml6 harness; the page instantiates cleanly
after dropping the assignment.
- Plasma pushes every config key as an initial property to every
config page and warns about missing ones; declare each page's
missing cfg_* properties to silence the journal noise.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues reported on a live Plasma 6 (Fedora KDE) session:
input-gaming-symbolicis a GNOME icon name; Breeze doesn't ship it and the icon lookup silently falls back to the full-colorinput-gaming(devices/64), which cannot be recolored, so the tint no-opped with nothing in the logs. The compact representation now uses Breeze'sinput-gamepad-symbolicwithfallback: "input-gaming-symbolic"for KDE setups running GNOME icon themes, plusisMask: trueso Kirigami applies the tint regardless of theme.Component is not ready,ConfigLighting.qml:130 Cannot assign to non-existent property "parent") — Qt 6'sQtQuick.Dialogs.ColorDialogdescends from QObject, not Item, so it has noparentproperty and the invalid binding aborted creation of the entire page. Dropped the assignment; the dialog picks up its window from its QML parent object automatically.Setting initial properties failed: ... cfg_rgb*journal warnings — Plasma pushes every config key as an initial property to every config page; each page now declares the keys owned by the other page. (The identical warnings from KDE's ownConfigurationShortcuts/AboutPluginpages are upstream shell behavior and can't be silenced from the plasmoid.)Test plan
Qt.labs.platform/plasma5supportmodules) reproduces the exact journal error on the oldConfigLighting.qmland instantiates both config pages cleanly after the fixcoloralone → 0/2083 icon pixels tinted;color+isMask: true→ 2083/2083 tinted; the exact fixed icon config (source + fallback + isMask) renders fully tinted in battery green#2ec27eqmllinton all touched QML files: no new warnings (only pre-existing import-path noise on this non-Plasma dev machine)🤖 Generated with Claude Code