Repository navigation
feat(plugin-launcher): one 48px rounded tile per item and a wider panel - #2112
Merged
Merged
Conversation
added 3 commits
November 5, 2026 11:18
The 34px icon left room for a type badge but not for the name: at the previous default width a tile had about 40px of text and truncated after three characters. Every source now renders the same 48px rounded square, the badge is gone, and the name owns the whole line under the icon. The window opens at 900 DIP and refuses to go below 800, which is the narrowest width where an eight-column row still fits the icon and a readable name. The trade-off is explicit: a plugin and an application look identical until one is opened, and the hover title is the only place that still names the source.
The spec still described a type badge, a square/round split and a 560 minimum width. It now states the two-part tile, the 48px shape, the 800/900 width floor and default, and that telling a plugin from an application is a deliberate non-goal covered only by the hover title. The ADR records the same trade-off in its consequences, and E2E-268 gains a same-name step so the behaviour is checkable by hand.
Brings the tile change onto the current base; no conflicts, the merge is purely additive against the launcher files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么
#2091 合并之后，按评审定稿的视觉方案继续调整插件快捷面板的格子：
--radius-lg= 16px），不再靠方形/圆形区分。18-plugin-launcher（中英）、ADR 0343、E2E-268；issue [Feature] 插件快捷面板：分组网格布局 + 正则带参唤起 + 启动本地应用 #2085 已相应改写。明确的取舍
插件与本地应用在打开之前不再可区分：外观完全一致，来源只保留在悬停
title里。这推翻了 issue 原文的「一眼分得开」，因此文档、ADR 的 Consequences 和 E2E-268 都改成「刻意不区分，同名两条都列出」，而不是只改 CSS。若之后要恢复区分，建议做悬停/页脚提示，而不是重新占掉每格的名字宽度。验证
node --testlauncher 相关 7 个套件 → 79 passed, 0 failed（含plugin-launcher-window新增断言：单一图标形状、icon-plugin/icon-app与tile-type已不存在）tsc -p apps/desktop --noEmit→ 通过biome lint→ 136 files，无问题node docs/scripts/check-docs.mjs→ 612 页；check-locales.mjs→ 89 对，均通过Refs #2085
Follows up #2091