Repository navigation
Retry stalled character catalog requests - #84
Merged
Merged
Conversation
The miHoYo wiki request could stall for 20+ seconds on some CDN nodes with no timeout, no retry and no log, leaving Genshin/HSR character lists empty. - Each catalog request (wiki, Endfield, HoYoWiki, GameBanana categories) times out after 20 s and is retried once on a stall or network error. - Repositories without a recognisable wiki address fall back to the built-in wiki of the matching game. - Retries and failures are written to app-errors.log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some users' Genshin and Star Rail character lists never loaded from the miHoYo wiki. Only English names gathered from GameBanana showed, in alphabetical order.
The wiki request sometimes stalls for 20 seconds or more, and which game it hits changes from run to run. The likely cause is miHoYo's CDN rotating to a node that can't be reached, but this wasn't confirmed. Three things made it worse:
Repositories without a recognisable wiki address also never loaded a wiki catalog at all.
Changes
CharacterCatalogClient.WithRetryAsync: every catalog request (miHoYo wiki, Endfield, HoYoWiki, GameBanana categories) times out after 20 s. It is retried once after a timeout or network error, but not when the caller cancels or on any other error.CharacterCatalogClient.Describe(wikiUrl, gameWikiUrl): when the repository's own wiki address isn't recognised, the built-in wiki of the matching game is used.app-errors.log, so it shows up in diagnostic reports.Tests
scripts/test-all.ps1: Core 1606, Data 24, Updater 32, Endfield 47, all passing; style check clean.🤖 Generated with Claude Code