Repository navigation
Keep same-named folders the manager did not copy (#107) - #114
Merged
Merged
Conversation
Copy-mode deployments are recorded in beta-shell.json (CopyDeployments), never as files inside Mod folders. A same-named folder in the loader folder counts as a Mod's copy only when it was recorded or, for copies made before the records existed, when its file list and every file size equal the repository Mod (strict choice A). Anything else is an external folder: the preset preview lists it, keeps it out of the removal plan and offers to take it over; a single toggle asks before removing one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.
Summary
In copy mode, restoring a combination preset recognised a deployed Mod by folder name alone, so an unrelated folder with the same name could be planned for removal. The manager now records the copies it makes and only removes what it owns.
beta-shell.json): repository, source Mod, target path and file list. Nothing is written into Mod folders.Note for later: renaming a character (#108) doesn't update these records yet. That's a small follow-up once both PRs are in
main.Test plan
scripts\test-all.ps1after mergingmain: Release build 0 warnings; Core line coverage 94.0%, branch 88.1%Reproduce_CopyPresetRemovesUnrelatedSameNamedFoldernow checks that the unrelated folder survives the restore.Ledger_*: claiming an identical old copy, refusing an edited one or one with an extra or missing file, records for another source, and forgetting a removed copy.Plan_*: keeping an unrelated folder out of the removal, never installing over an external folder, external junctions, removing a recorded copy.Preview_*andCapture_*: showing and keeping external folders, blocking the restore, taking over, choosing between two sources with the same name.🤖 Generated with Claude Code