Skip to content

Stage J4-b: first-run game cards, getting-started tips and a hideable search box - #110

Merged
uyujkk merged 3 commits into
mainfrom
claude/ui-j4b-first-run
Nov 9, 2026
Merged

uyujkk merged 3 commits into
mainfrom
claude/ui-j4b-first-run

Conversation

@uyujkk

@uyujkk uyujkk commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

Stage J4-b of the Fluent design plan (docs/development/UI-Fluent-Design-Plan.md, "仪表盘(J4)"), plus follow-ups from the maintainer's review.

  • 6d3439b: remembers the getting-started tips after a first install. The rule is in Core/Configuration/GettingStartedTips.cs, with unit tests.
    • Only a first install starts the tips. They are saved as GettingStartedTipsPending in beta-shell.json; older settings files don't have the field, so upgrading users never see them.
    • If you quit without closing them, they come back from step 1 on the next start.
    • They wait until the startup dialogs are closed and only show on the Dashboard.
  • d71973b: the first-run dialog shows each game as a card, two per row, with a note on what comes next (set the paths, then open Mod management).
    • One TeachingTip on the Dashboard points in turn at New repository, the paths and Open Mod management, with "Step 1 of 3", Skip tips and Next/Done.
    • Focus moves to Next when the tip opens, and Narrator reads the step's title and text.
    • Esc, Skip tips, ✕ or Done close it for good.
  • 961d04d: review follow-ups.
    • No "what's new" on a first install: a new install treats the current feature set as already seen (WhatsNewPolicy, with unit tests), so the tips come straight after the game choice. Upgrading users still see the dialog once.
    • Narrator text: the title and text are joined with the language-file format GettingStarted.Announcement ({0}。{1} in Chinese).
    • The title-bar search box can be hidden: "Show the search box in the title bar" is a new on-by-default toggle in Appearance and language, saved as ShowTitleBarSearch (older settings count as on). Ctrl+K still opens the command palette when the box is hidden.
    • The first tip no longer covers the search box: step 1 opens below New repository (PreferredPlacement="BottomLeft").

Unchanged: how a first install is detected, the language following Windows, the fields saved for the chosen game, and "Set up later" leaving the repository without a game.

Not done: the plan's in-page "Getting started" card with a check mark per step. Ticking steps would need new rules for what counts as "paths set" and "Mods imported"; the tips point at those places instead. The reasoning is in the J4-b section of the plan.

Test plan

  • scripts\test-all.ps1: 1,688 Core tests (new ones for the tips and what's-new rules), Release build 0 warnings, coverage threshold unchanged
  • UI tests 30/30 on the same build (-Application). New tests:
    • The tips test checks focus, the Narrator help text, moving to the next step, coming back after a restart, closing with Esc, and staying closed.
    • The search-box test turns the box off, opens the palette with Ctrl+K, and checks the box stays hidden after a restart.
    • The first-install test now checks that no what's-new dialog appears.
  • Code-style check
  • 24 screenshots (Dashboard with tips and the Settings page, zh/en/ru × 1000×800 / 1400×900 × light/dark, plus a title bar with the search box off); no Russian truncation
  • Full package, clicked through with the mouse from a fresh install:
    • No what's-new dialog appeared; all three tips were stepped through; the search box was turned off.
    • 24 page switches, a restart, then 8 more. Neither the tips nor the search box came back.
    • The game choice was kept, and the error log is empty.
  • First-run dialog in English/Russian: it follows the Windows language, so only Chinese was captured

🤖 Generated with Claude Code

uyujkk and others added 3 commits November 9, 2026 02:45
A first install now marks the dashboard's getting-started tips as pending (new beta-shell.json field GettingStartedTipsPending). They are handed to the dashboard once the startup dialogs are closed and stay pending until closed or finished, so closing the app keeps them. Configs from before have no such field, so upgrades never see them. The tour's steps and rules are in Core (GettingStartedTips) with unit tests.

The first-install check, the system language, the chosen game's repository fields and "Set up later" are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first-run dialog shows each game as a card, two to a row, and a note on what comes next. On the dashboard one TeachingTip points at New repository, the paths and Open Mod management in turn ("Step 1 of 3", Skip tips, Next/Done). It takes the keyboard focus and announces the step for Narrator; Esc, Skip tips, its close button or Done close it for good.

UI test: the tips come back after a restart until Esc closes them, then stay closed. The screenshot script gains the gettingstarted page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A first install counts the current feature set as seen (WhatsNewPolicy, with unit tests), so the tips come straight after the game; upgrades still see "what's new" once.
- Narrator reads each tip through the language file's GettingStarted.Announcement format ("{0}。{1}" in Chinese) instead of a fixed ". ".
- Step 1 of the tips opens below the New repository button (BottomLeft), so it no longer covers the title bar's search box.
- Settings > Appearance and language gains "Show the search box in the title bar" (on by default, saved as ShowTitleBarSearch; older configs count as on). Ctrl+K opens the palette either way.

UI tests: the first-install test now checks that no what's-new dialog appears; a new test turns the search box off, opens the palette with Ctrl+K and checks it stays hidden after a restart. The screenshot script gains the nosearch page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@uyujkk
uyujkk merged commit 6d2adc3 into main Nov 9, 2026
4 checks passed
@uyujkk
uyujkk deleted the claude/ui-j4b-first-run branch November 16, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant