Repository navigation
Major code cleanup: - #24
Merged
Merged
Conversation
VorpalBlade
commented
Aug 6, 2020
VorpalBlade
commented
Contributor
- Reformatting (this is split in two due to the required rebase in the middle, too difficult to reorder commits around this). I used YAPF for this, no particular reason other than that it is standalone and seems reasonably popular.
- Fixing several small issues found by the code inspection in the PyCharm IDE.
- Adding some typing information
- Simply the blob design, while still auto loading, the exported symbols are now at least plainly visible to IDEs and tooling.
PEP8 settings are used except the low 80 column limit has be increased to a more reasonable 100 columns.
These are dangerous as you will import not only the functions defined in the other module but also all of it's imports! This makes automated cleanups brittle.
This sorts imports into sections: * From standard library * From other libraries * From the current project Each section is sorted alphabetically.
uunicorn
reviewed
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.