Skip to content

unsloth: pin #253 (no CUDA graph cache count cap) in place of #241 - #256

Merged
danielhanchen merged 1 commit into
masterfrom
pin-253-cuda-graph-cap
Oct 8, 2026
Merged

danielhanchen merged 1 commit into
masterfrom
pin-253-cuda-graph-cap

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Pins #253 (no count cap on the CUDA graph cache) in place of #241.

#253 is #241 plus one commit. That commit removes the 64 entry LRU cap that the shape keyed graph cache from #241 added. With the cap, tensor split re-captures graphs on every token, because it needs about 2 * n_layers + 1 graphs per device. The result is 2.4x to 4.3x slower decode than the official build (unslothai/unsloth#12468). Upstream dropped the same cap in review of ggml-org#21611.

Why replace #241 rather than add #253 after it

Verification

Merge loop (diff3, then additive_merge.py, as unsloth-prebuilt.yml runs it) plus pin_contract.py:

Base Merge pin_contract
b11493 15/15, 2 additive (Inkling, #70) all 15 intact
b11500 15/15, 2 additive all 15 intact
upstream master c811cb8f0 15/15, 2 additive all 15 intact

The feature-checks.json coverage lint passes: 15 pins, 7 with a feature check, 8 knowingly unchecked.

…nt cap

#253 is #241 plus one commit that removes the 64 entry cap on the shape keyed
CUDA graph cache, which made tensor split re-capture graphs on every token
(unslothai/unsloth#12468). Its branch now merges #241's current head, so
pinning it instead of #241 carries every #241 item and the fix, and keeps
pin_contract from reading the removed cap lines as a lost #241 change.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T15:46:56.932164Z 3d974a0 PR opened
🔒 Security Review ✅ Completed 2026-10-08T15:49:57.889754Z 3d974a0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant