Add setting to remove unnecessary labels - #790
Open
schuessf wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
26cbad3 introduced an optimization in
IcfgBuilderto remove unnecessary labels (i.e., labels without a goto, or where the only goto is immediately preceding the label) from the CFG. However, this optimization was too aggressive: #713 introduced the concept of locations of interest (LOIs), and non-auxiliary labels are meant to be treated as LOIs and should therefore always be preserved in the CFG. This was fixed in e158e9d by restricting the optimization to auxiliary labels only, so non-auxiliary labels are now always kept as LOIs. However, in cases where we are not interested in invariants at labels (e.g. SV-COMP), we'd still like the more aggressive optimization to reduce CFG size.This PR adds a setting controlling whether the label-removal optimization applies to all labels (not just auxiliary ones), for cases where preserving LOIs at labels isn't required. By default, the setting is enabled, i.e., it behaves the same as before e158e9d. For stricter handling of labels (e.g., if you expect invariants at every label in Referee), you can disable the setting.