Complete rt-inconsistency check - #784
Open
hauff wants to merge 78 commits into
Open
Conversation
Pre Check is implemeneted before actual rt-inconsistency pre check and returns subsets with possible sets
Add optionsto preferences to enable/disable rt-check. Also addes preferences for range/number of chain-link requriements
…ltimate into wip/mf/rtiPreCheck
…ltimate into wip/mf/rtiPreCheck
…ltimate into wip/mf/rtiPreCheck
minimum status 1% assuming of remaining chains
Changed % from 0.1 to 1%
used wrong formula for chain > 2, fixed now
…ltimate into wip/mf/rtiPreCheck
Member
|
Could you rebase this PR, then I can take a look. |
- Implemented complete rt-Inconsistency pre-check
hauff
force-pushed
the
wip/mf/rtiPreCheck
branch
from
June 12, 2026 10:09
e839dfe to
1829bd8
Compare
Contributor
Author
@danieldietsch done. |
danieldietsch
requested changes
Jun 30, 2026
| ARCH="linux" | ||
| ARCHPATH="products/CLI-E4/linux/gtk/x86_64" | ||
| ADDS+=("adds/z3" "adds/cvc4nyu" "adds/cvc4" "adds/mathsat") | ||
| ADDS+=("adds/z3" "adds/cvc4nyu" "adds/cvc4" "adds/mathsat" "adds/mus_enumerator") |
Member
There was a problem hiding this comment.
Does mus_enumerator have a licence? You also need to add some info to our READMEs.
Contributor
Author
There was a problem hiding this comment.
@danieldietsch Yes it should have a license. I don't know which, maybe you can help me here?
The implementation is basically from this example.
I also would like to add the python code instead of the binary, but I had problems with the dependency z3.
| private final IIdentifierTranslator[] mIdentifierTranslators; | ||
| private final IReqSymbolTable mReqSymboltable; | ||
| private final Boogie2SMT mBoogieToSmt; | ||
| protected final Boogie2SMT mBoogieToSmt; |
Member
There was a problem hiding this comment.
You might add methods to CddToSMT to do what you need in your subclass?
…into wip/mf/rtiPreCheck
hauff
force-pushed
the
wip/mf/rtiPreCheck
branch
from
July 26, 2026 14:59
dcdb92c to
e8270cc
Compare
hauff
force-pushed
the
wip/mf/rtiPreCheck
branch
2 times, most recently
from
July 26, 2026 20:05
569ec08 to
9ccbd0e
Compare
hauff
force-pushed
the
wip/mf/rtiPreCheck
branch
from
July 26, 2026 20:08
9ccbd0e to
3ef4ea6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the existing rt-inconsistency analysis such that it uses a pre-computed candidate set.