Repository navigation
Conversation
llama_ids() and the perplexity sample in main() both created NamedTemporaryFile(delete=False) and never removed the file, leaking a temp file per page per GGUF (and one more for the perplexity text sample) into the OS temp dir on every run. delete=False still has to stay since llama-tokenize/llama-perplexity read the path after the with block closes the handle, so wrap the subprocess usage in try/finally and os.unlink() once it is done.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both temp-file sites in gguf/check_gguf.py create a NamedTemporaryFile(delete=False, ...) and never remove the file afterward:
delete=False has to stay, since llama-tokenize/llama-perplexity read the path after the with block closes the file handle. This wraps the subsequent usage in try/finally and calls os.unlink() once each file is no longer needed, so the temp dir does not accumulate files run after run.