Repository navigation
Conversation
app.py decided whether to load the model from the local folder or the hub by checking only for model.safetensors. ChitraTiny.from_pretrained needs both config.json and model.safetensors once it takes the local path, with no handling for a missing config. If someone ends up with a stray or partial model.safetensors locally (interrupted download, manual copy, etc.) without config.json, the app crashes with an unhandled FileNotFoundError instead of falling back to the hub download. Now the local-path check requires both files, matching what from_pretrained actually needs.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app.py picks the local folder vs. the hub repo by checking only for
model.safetensors:
But ChitraTiny.from_pretrained (chitra_tiny.py) requires both
config.json and model.safetensors once it takes the local-path branch,
and does the config.json read with no try/except:
So if model.safetensors exists locally but config.json doesn't (partial
download, a weights file copied in by hand, etc.), the app crashes with
an unhandled FileNotFoundError instead of falling back to downloading
from the hub.
This PR makes app.py's local-path check require both files, which
matches what from_pretrained actually needs and lets it fall back to
the hub download when the local folder is incomplete.