Repository navigation
feat: expand plugin scaffolds and scenario coverage - #139
Conversation
# Conflicts: # bun.lock # example/convex/functions/generated/server.ts # package.json # packages/better-convex/package.json # packages/better-convex/src/auth/create-schema.ts # packages/better-convex/src/auth/generated-contract.ts # packages/better-convex/src/cli/codegen.test.ts # packages/better-convex/src/cli/codegen.ts # packages/better-convex/src/cli/watcher.test.ts # packages/better-convex/src/cli/watcher.ts # packages/better-convex/src/crpc/types.ts # vitest.config.mts # www/content/docs/orm/schema/triggers.mdx
# Conflicts: # packages/better-convex/src/cli/env.ts # www/content/docs/auth/server.mdx
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78c38f9cd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38c9e8f7f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d1c3485dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 738b4116de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
https://github.com/udecode/better-convex/blob/9096168f35da5832a2977d8f0fdcdfc31940f708/packages/kitcn/src/cli/codegen.ts#L943
emitGeneratedAuthFile always emits import schema ... even when auth is disabled and ORM schema metadata is absent. Since codegen still writes generated/auth.ts for default scopes, schema-less Convex projects end up with a generated file importing schema.ts that may not exist, which breaks subsequent typecheck/build despite auth being disabled.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da40894f76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba70af965e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42d4a188dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19ce505bdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b891a3ecd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| clientSiteUrlEnvKey: 'VITE_SITE_URL', | ||
| convexUrlEnvKey: 'VITE_CONVEX_URL', | ||
| convexSiteUrlEnvKey: 'VITE_CONVEX_SITE_URL', |
There was a problem hiding this comment.
next-pages is routed through the generic React scaffold branch, which hardcodes VITE_* env keys here. Downstream, handleAddCommand reads projectContext.convexUrlEnvKey to validate raw Convex auth setup (packages/kitcn/src/cli/commands/add.ts), so a valid Next Pages app that correctly uses NEXT_PUBLIC_CONVEX_URL is rejected as “deployment not ready.” This blocks kitcn add auth flows on supported Next Pages projects.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39039d4e72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const parsed = parseArgs(argv); | ||
| const commandIndex = argv.indexOf(parsed.command); | ||
| const prefix = commandIndex >= 0 ? argv.slice(0, commandIndex) : []; | ||
| return [...prefix, 'dev', '--once', ...parsed.restArgs]; |
There was a problem hiding this comment.
buildVerifyDevArgv rebuilds the delegated dev command from parsed.restArgs, but parseArgs strips global options like --config and --api before they ever reach restArgs. When users run kitcn verify --config <path> or kitcn verify --api <dir> (flags after the command), those overrides are silently dropped and handleDevCommand runs with defaults, so verification can execute against the wrong config/shared directory and report misleading results.
Useful? React with 👍 / 👎.
| const targetArgs = extractBackendRunTargetArgs(backend, parsed.convexArgs); | ||
| if (getAggregateBackfillDeploymentKey(targetArgs) !== 'local') { |
There was a problem hiding this comment.
The local-only safety check only inspects parsed.convexArgs, but handleDevCommand later prepends config.dev.args to the effective dev argv. If concave.json sets dev.args to remote selectors like --prod/--deployment-name, kitcn verify passes the local-only check and then still runs against a remote deployment, violating the command's stated local-only contract.
Useful? React with 👍 / 👎.
Summary
Validation