Cleanup of time - #781
Merged
Merged
Cleanup of time#781
Conversation
Mostly nits about naming, and moving the Cogen tests to one place, but also adding a new Choose suite separate from Gen.
Contributor
Author
|
I'm going to merge. I have further small followup changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some follow-up changes to the java.time.* contribution in #734. They're mostly naming cleanup, but it also includes putting the Cogen tests together in one place, and also adopting a ChooseSpecification for other existing tests as a way to lighten up the huge GenSpecification suite.