Move NoOpLogger to core module#778
Merged
Merged
Conversation
TonioGela
approved these changes
Aug 16, 2023
TonioGela
left a comment
TonioGela
left a comment
Member
There was a problem hiding this comment.
My approval is not needed but I like it, so I'll approve it :)
danicheg
approved these changes
Aug 17, 2023
danicheg
left a comment
danicheg
left a comment
Member
There was a problem hiding this comment.
Giving strength and legitimacy to the approvals above
lenguyenthanh
added a commit
to lenguyenthanh/fide
that referenced
this pull request
May 4, 2024
As it is moved to core module: typelevel/log4cats#778
lenguyenthanh
added a commit
to lenguyenthanh/fide
that referenced
this pull request
May 4, 2024
As it is moved to core module: typelevel/log4cats#778
lenguyenthanh
added a commit
to lichess-org/lila-fishnet
that referenced
this pull request
May 4, 2024
As it is moved to core module: typelevel/log4cats#778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
noopmodule depends oncorethe final binary interface is identical. So, this is a compatible change, and we will keep enforcing that compatibility going forwards.