Repository navigation
Remove confusing unnecessary id/aria-labelledby for dropdown menus - #36487
Merged
patrickhlauke merged 3 commits intoJun 3, 2022
Merged
Conversation
see #35755 Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
patrickhlauke
marked this pull request as ready for review
June 2, 2022 17:29
patrickhlauke
added
docs
julien-deramond
approved these changes
Jun 2, 2022
julien-deramond
left a comment
julien-deramond
left a comment
Member
There was a problem hiding this comment.
LGTM! Haven't found any other things to delete.
I suppose it should be backported to v4-dev after the merge.
mdo
approved these changes
Jun 3, 2022
patrickhlauke
added a commit
that referenced
this pull request
Jun 3, 2022
patrickhlauke
added a commit
that referenced
this pull request
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #35755
Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use
aria-controls, which in most current browser/AT combos is borked though)