Skip to content

V5 Grid System docs issues #33670

Closed
Closed

Description

@kohheepeace

I've found docs issue at
https://getbootstrap.com/docs/5.0/layout/grid/#example

📌 Issue

2021-04-18_19h41_22

Does col-sm creates three equal-width columns across all devices and viewports?

📌 Issue example

The below image is layout of iPhone 6 plus. It doesn't create 3 columns.
2021-04-18_19h49_17

📌 Docs at v4.6

I think docs at v4.6 is correct.
https://getbootstrap.com/docs/4.6/layout/grid/#how-it-works

The above example creates three equal-width columns on small, medium, large, and extra large devices using our predefined grid classes. Those columns are centered in the page with the parent .container.

PR

If this is an issue that needs to be fixed, I'd like to send a PR.

Thanks !

Environment

Operating system and version: Windows
Browser and version: Chrome 89.0.4389.114

Activity

  1. ffoodd commented on Apr 18, 2021

    @ffoodd
    Contributor

    I agree, this is a wrong assertion: either get the 4.6 docs sentence back or get rid off -sm suffix to make the sentence true. The latter would require to reword columns content (maybe something like "⅓ column").

  2. added
    docsDocumentation site and its content
    v5v5, the v5-dev branch
    on Apr 18, 2021
  3. kohheepeace commented on Apr 18, 2021

    @kohheepeace
    ContributorAuthor

    I think it would be better to remove the sm prefix.

    Because the following code is the simplest grid system example.

    <div class="container">
      <div class="row">
        <div class="col">
        </div>
        ...
      </div>
    </div>

    It also makes sense to separate this "example" section from the "How it works" section in v5.0

  4. mdo commented on Apr 19, 2021

    @mdo
    Member

    Closed by #33676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation site and its contentv5v5, the v5-dev branch

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions