Repository navigation
Conversation
A noExcess wrapper became an empty schema, and a strict intersection became allOf members that reject each other's keys. Read the wrapper and merge those members into one object. Co-authored-by: Cursor <cursoragent@cursor.com>
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/custom-function-types
@transcend-io/design-tokens
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/secret-value
@transcend-io/type-utils
@transcend-io/utils
commit: |
Supporting noExcess in toJsonSchema is a new capability, not a fix to existing schema output. Co-authored-by: Cursor <cursoragent@cursor.com>
A record or refinement member stayed an open allOf, so the schema allowed keys that noExcess rejects. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
toJsonSchemanow convertsnoExcesscodecs.Related Issues
Summary
noExcess(codec)used to fall through tounhandledTypeand become{}.NoExcessTypeis now part ofMappableTypeand gets its own branch.additionalProperties: falseon that object only. Nested objects keep the caller'sstrictsetting, which matches the runtime check innoExcess.additionalProperties: falseon eachallOfmember would otherwise reject the other members' keys.alwaysIncludeRequiredintersection path through a newmergeObjectSchemashelper. That path's output is unchanged.@transcend-io/type-utils.