Repository navigation
Support for flatten(nullable) in sqlx::FromRow - #4431
Open
Niedzwiedzw wants to merge 4 commits into
Open
Niedzwiedzw wants to merge 4 commits into
Niedzwiedzw wants to merge 4 commits into
Conversation
Contributor
|
This tries to parse the type which is fragile. What if someone does something like: type Opt<T> = Option<T>;and use #3667 uses auto ref based specialization, see #3667 (comment) |
Author
|
Well I thought about it but I think aliasing Option is obscure enough it can be skipped, as the error will be clear and solution is just to move it to a different module without an alias. |
Author
|
|
Niedzwiedzw
force-pushed
the
feat/flatten-nullable
branch
from
September 29, 2026 09:28
948411d to
1da04cb
Compare
sqlx::FromRow
sqlx::FromRowflatten(nullable) in sqlx::FromRow
Niedzwiedzw
marked this pull request as ready for review
September 29, 2026 09:35
Author
|
@joeydewaal after giving it some thought you're right it's better to not parse the option, I pushed an update which uses associated type to extract inner type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #2934
Do not just list issue numbers here as they will not be automatically closed on merging this pull request unless prefixed with "fixes" or "closes".
Is this a breaking change?
No, default behaviour is preserved
If yes, this pull request will need to wait for the next major release (
0.{x + 1}.0)Probably would still be worth it